Symphony.constructor - Code Metrics - Inspection of "[Snyk Update] New fixes for 4 vulnerable dependenc..." - symphonycms/symphony-2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2833)

unknown

created 2018-05-07 21:03 UTC

Symphony.constructor B

↳ Parent: Project

Complexity

Conditions	2
Paths	88

Size

Total Lines

397

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
c	0
b	0
f	0
nc	88
nop	2
dl	0
loc	397
rs	8.2857

18 Functions

Rating	Name	Size	Complexity
A	symphony.js ➔ ... ➔ $.each	3	1
A	symphony.js ➔ replaceVariables	8	3
A	symphony.js ➔ ???	1	1
A	symphony.js ➔ addRoute	12	2
B	symphony.js ➔ translate	35	4
A	Symphony.Utilities.cancelAnimationFrame	3	1
A	symphony.js ➔ getString	14	2
A	symphony.js ➔ ... ➔ $.ajax.success	3	1
B	symphony.js ➔ addContext	20	5
A	Symphony.Utilities.getXSRF	10	2
A	symphony.js ➔ addStrings	23	3
A	symphony.js ➔ inSight	21	1
A	symphony.js ➔ ... ➔ $.ajax.error	3	1
A	Symphony.Utilities.requestAnimationFrame	3	1
A	symphony.js ➔ renderRoute	13	3
A	symphony.js ➔ getContext	15	3
B	symphony.js ➔ ... ➔ elements.each	14	8
A	symphony.js ➔ ... ➔ checkStrings	5	2

How to fix Long Method

/*!
 * Symphony 2.7.x, https://www.getsymphony.com, MIT license
 */

/**
 * @package assets
 */

/**
 * The Symphony object provides language, message and context management.
 *
 * @class
 */
var Symphony = (function($, crossroads) {

	// Internal Symphony storage
	var Storage = {
		Context: {},
		Dictionary: {},
		Support: {}
	};

/*-------------------------------------------------------------------------
	Functions
-------------------------------------------------------------------------*/

	// Replace variables in string
	function replaceVariables(string, inserts) {
		if($.type(string) === 'string' && $.type(inserts) === 'object') {
			$.each(inserts, function(index, value) {
				string = string.replace('{$' + index + '}', value);

			});
		}
		return string;
	}

	// Get localised strings
	function translate(strings) {
		var env = Symphony.Context.get('env');
		if (!env) {
			// no env, can't continue
			return;
		}
		var namespace = $.trim(env['page-namespace']),
			data = {
				'strings': strings
			};

		// Validate and set namespace
		if($.type(namespace) === 'string' && namespace !== '') {
			data.namespace = namespace;
		}

		// Request translations
		$.ajax({
			async: false,
			type: 'GET',
			url: Symphony.Context.get('symphony') + '/ajax/translate/',
			data: data,
			dataType: 'json',

			// Add localised strings
			success: function(result) {
				$.extend(true, Storage.Dictionary, result);
			},

			// Use English strings on error
			error: function(jqXHR, textStatus, errorThrown) {

				$.extend(true, Storage.Dictionary, strings);
			}
		});
	}

	// request animation frame
	var raf = window.requestAnimationFrame || window.mozRequestAnimationFrame ||  
		window.webkitRequestAnimationFrame || window.msRequestAnimationFrame ||
		window.oRequestAnimationFrame || function (f) { return window.setTimeout(f, 16/1000) };
	var craf = window.cancelAnimationFrame || window.webkitCancelRequestAnimationFrame ||
		window.mozCancelRequestAnimationFrame || window.oCancelRequestAnimationFrame ||
		window.msCancelRequestAnimationFrame  || function (t) { window.clearTimeout(t); };
	

/*-----------------------------------------------------------------------*/

	// Set browser support information
	try {
		Storage.Support.localStorage = !!localStorage.getItem;

	} catch(e) {
		Storage.Support.localStorage = false;
	}

	// Deep copy jQuery.support
	$.extend(true, Storage.Support, $.support);

/*-------------------------------------------------------------------------
	Symphony API
-------------------------------------------------------------------------*/

	return {

		/**
		 * Symphony backend view using Crossroads
		 *
		 * @since Symphony 2.4
		 */
		View: {

			/**
			 * Add function to view
			 *
			 * @param {String} pattern
			 *  Expression to match the view, using the Symphony URL as base
			 * @param {Function} handler
			 *  Function that should be applied to a view
			 * @param {Integer} priority
			 *  Priority of the function
			 * @param {Boolean} greedy
			 *  If set to `false`, only executes the first matched view, defaults to `true`
			 * @return {Route}
			 *  Returns a route object
			 */
			add: function addRoute(pattern, handler, priority, greedy) {
				var route;

				pattern = Symphony.Context.get('path') + pattern;

				route = crossroads.addRoute(pattern, handler, priority);

				if(greedy !== false) {
					route.greedy = true;
				}

				return route;
			},

			/**
			 * Render given URL, defaults to the current backend URL
			 *
			 * @param {String} url
			 *  The URL of the view that should be rendered, optional
			 * @param {Boolean} greedy
			 *  Determines, if only the first or all matching views are rendered,
			 *  defaults to `true (all)
			 */
			render: function renderRoute(url, greedy) {

				if(!url) {

					url = Symphony.Context.get('path') + Symphony.Context.get('route');

				}

				if(greedy === false) {
					crossroads.greedyEnabled = false;
				}

				crossroads.parse(url);
			}

		},

		/**
		 * Storage for the main Symphony elements`.
		 * Symphony automatically adds all main UI areas.
		 *
		 * @since Symphony 2.4
		 */
		Elements: {
			window: null,
			html: null,
			body: null,
			wrapper: null,
			header: null,
			nav: null,
			session: null,
			context: null,
			contents: null
		},

		/**
		 * The Context object contains general information about the system,
		 * the backend, the current user. It includes an add and a get function.
		 * This is a private object and can only be accessed via add and get.
		 *
		 * @class
		 */
		Context: {

			/**
			 * Add data to the Context object
			 *
			 * @param {String} group
			 *  Name of the data group
			 * @param {String|Object} values
			 *  Object or string to be stored
			 */
			add: function addContext(group, values) {

				// Add multiple groups
				if(!group && $.type(values) === 'object') {
					$.extend(Storage.Context, values);
				}

				// Add to existing group
				else if(Storage.Context[group] && $.type(values) !== 'string') {
					$.extend(Storage.Context[group], values);
				}

				// Add new group
				else {
					Storage.Context[group] = values;
				}

				// Always return
				return true;
			},

			/**
			 * Get data from the Context object
			 *
			 * @param {String} group
			 *  Name of the group to be returned
			 */
			get: function getContext(group) {

				// Return full context, if no group is set
				if(!group) {
					return Storage.Context;
				}

				// Return false if group does not exist in Storage
				if(typeof Storage.Context[group] === 'undefined') {
					return false;
				}

				// Default: Return context group
				return Storage.Context[group];
			}
		},

		/**
		 * The Language object stores the dictionary with all needed translations.
		 * It offers public functions to add strings and get their translation and
		 * it offers private functions to handle variables and get the translations via
		 * an synchronous AJAX request.
		 * Since Symphony 2.3, it is also possible to define different translations
		 * for the same string, by using page namespaces.
		 * This is a private object
		 *
		 * @class
		 */
		Language: {

			/**
			 * Add strings to the Dictionary
			 *
			 * @param {Object} strings
			 *  Object with English string as key, value should be false
			 */
			add: function addStrings(strings) {

				// English system
				if(Symphony.Context.get('lang') === 'en') {
					$.extend(true, Storage.Dictionary, strings);
				}

				// Localised system
				else {

					// Check if strings have already been translated
					$.each(strings, function checkStrings(index, key) {
						if(key in Storage.Dictionary) {
							delete strings[key];
						}
					});

					// Translate strings
					if(!$.isEmptyObject(strings)) {
						translate(strings);
					}
				}
			},

			/**
			 * Get translated string from the Dictionary.
			 * The function replaces variables like {$name} with the a specified value if
			 * an object of inserts is passed in the function call.
			 *
			 * @param {String} string
			 *  English string to be translated
			 * @param {Object} inserts
			 *  Object with variable name and value pairs
			 * @return {String}
			 *  Returns the translated string
			 */
			get: function getString(string, inserts) {
				var translation = Storage.Dictionary[string];

				// Validate and set translation
				if($.type(translation) === 'string') {
					string = translation;

				}

				// Insert variables
				string = replaceVariables(string, inserts);

				// Return translated string
				return string;
			}
		},

		/**
		 * A collection of properties that represent the presence of
		 * different browser features and also contains the test results
		 * from jQuery.support.
		 *
		 * @class
		 */
		Support: Storage.Support,

		/**
		 * A namespace for core interface components
		 *
		 * @since Symphony 2.6
		 */
		Interface: {},

		/**
		 * A namespace for extension to store global functions
		 *
		 * @since Symphony 2.3
		 */
		Extensions: {},

		/**
		 * Helper functions
		 *
		 * @since Symphony 2.4
		 */
		Utilities: {

			/**
			 * Get a jQuery object of all elements within the current viewport
			 *
			 * @since Symphony 2.4
			 */
			inSight: function inSight(elements) {
				var windowHeight = window.innerHeight,
					visibles = $();

				elements.each(function() {
					var context = this.getBoundingClientRect();

					if(
						(context.top >= 0 && context.top <= windowHeight) || // Element top in sight
						(context.bottom >= 0 && context.bottom <= windowHeight) || // Element bottom in sight
						(context.top <= 0 && context.bottom >= windowHeight) // Element overflowing viewport
					) {
						visibles = visibles.add(this);

					}
					else if (visibles.length > 0) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
						return false;
					}
				});

				return visibles;
			},

			/**
			 * Returns the XSRF token for the backend
			 *
			 * @since Symphony 2.4
			 * @param boolean $serialised
			 *  If passed as true, this function will return the string as a serialised
			 *  form elements, ie. field=value. If omitted, or false, this function
			 *  will just return the XSRF token.
			 */
			getXSRF: function(serialised) {
				var xsrf = Symphony.Elements.contents.find('input[name=xsrf]').val();

				if(serialised === true) {
					return 'xsrf=' + encodeURIComponent(xsrf);
				}
				else {

					return xsrf;
				}
			},

			/**
			 * Cross browser wrapper around requestFrameAnimation
			 *
			 * @since Symphony 2.5
			 * @param function $func
			 *  The callback to schedule for frame animation
			 */
			requestAnimationFrame: function (func) {
				return raf.call(window, func);
			},

			/**
			 * Cross browser wrapper around cancelAnimationFrame
			 *
			 * @since Symphony 2.5
			 * @param Integer $t
			 *  The request id
			 */
			cancelAnimationFrame: function (t) {
				return craf.call(window, t);
			}
		}
	};
}(window.jQuery, window.crossroads));


1			/*!
2			* Symphony 2.7.x, https://www.getsymphony.com, MIT license
3			*/
4
5			/**
6			* @package assets
7			*/
8
9			/**
10			* The Symphony object provides language, message and context management.
11			*
12			* @class
13			*/
14			var Symphony = (function($, crossroads) {
15
16			// Internal Symphony storage
17			var Storage = {
18			Context: {},
19			Dictionary: {},
20			Support: {}
21			};
22
23			/*-------------------------------------------------------------------------
24			Functions
25			-------------------------------------------------------------------------*/
26
27			// Replace variables in string
28			function replaceVariables(string, inserts) {
29			if($.type(string) === 'string' && $.type(inserts) === 'object') {
30			$.each(inserts, function(index, value) {
31			string = string.replace('{$' + index + '}', value);
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-04-27 20:50 UTC by Report Bug Copy Issue Report This re-assigns to the parameter `string`. Re-assigning to parameters often makes code less readable, consider introducing a new variable instead. Loading history...
32			});
33			}
34			return string;
35			}
36
37			// Get localised strings
38			function translate(strings) {
39			var env = Symphony.Context.get('env');
40			if (!env) {
41			// no env, can't continue
42			return;
43			}
44			var namespace = $.trim(env['page-namespace']),
45			data = {
46			'strings': strings
47			};
48
49			// Validate and set namespace
50			if($.type(namespace) === 'string' && namespace !== '') {
51			data.namespace = namespace;
52			}
53
54			// Request translations
55			$.ajax({
56			async: false,
57			type: 'GET',
58			url: Symphony.Context.get('symphony') + '/ajax/translate/',
59			data: data,
60			dataType: 'json',
61
62			// Add localised strings
63			success: function(result) {
64			$.extend(true, Storage.Dictionary, result);
65			},
66
67			// Use English strings on error
68			error: function(jqXHR, textStatus, errorThrown) {
			0 ignored issues – show Unused Code introduced 2018-05-07 21:13 UTC by Report Bug Copy Issue Report The parameter `errorThrown` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history... Unused Code introduced 2018-05-07 21:13 UTC by Report Bug Copy Issue Report The parameter `textStatus` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history... Unused Code introduced 2018-05-07 21:13 UTC by Report Bug Copy Issue Report The parameter `jqXHR` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
69			$.extend(true, Storage.Dictionary, strings);
70			}
71			});
72			}
73
74			// request animation frame
75			var raf = window.requestAnimationFrame \|\| window.mozRequestAnimationFrame \|\|
76			window.webkitRequestAnimationFrame \|\| window.msRequestAnimationFrame \|\|
77			window.oRequestAnimationFrame \|\| function (f) { return window.setTimeout(f, 16/1000) };
78			var craf = window.cancelAnimationFrame \|\| window.webkitCancelRequestAnimationFrame \|\|
79			window.mozCancelRequestAnimationFrame \|\| window.oCancelRequestAnimationFrame \|\|
80			window.msCancelRequestAnimationFrame \|\| function (t) { window.clearTimeout(t); };
81
82
83			/-----------------------------------------------------------------------/
84
85			// Set browser support information
86			try {
87			Storage.Support.localStorage = !!localStorage.getItem;
			0 ignored issues – show Bug introduced 2018-04-27 20:50 UTC by Report Bug Copy Issue Report The variable `localStorage` seems to be never declared. If this is a global, consider adding a `/** global: localStorage */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
88			} catch(e) {
89			Storage.Support.localStorage = false;
90			}
91
92			// Deep copy jQuery.support
93			$.extend(true, Storage.Support, $.support);
94
95			/*-------------------------------------------------------------------------
96			Symphony API
97			-------------------------------------------------------------------------*/
98
99			return {
100
101			/**
102			* Symphony backend view using Crossroads
103			*
104			* @since Symphony 2.4
105			*/
106			View: {
107
108			/**
109			* Add function to view
110			*
111			* @param {String} pattern
112			* Expression to match the view, using the Symphony URL as base
113			* @param {Function} handler
114			* Function that should be applied to a view
115			* @param {Integer} priority
116			* Priority of the function
117			* @param {Boolean} greedy
118			* If set to `false`, only executes the first matched view, defaults to `true`
119			* @return {Route}
120			* Returns a route object
121			*/
122			add: function addRoute(pattern, handler, priority, greedy) {
123			var route;
124
125			pattern = Symphony.Context.get('path') + pattern;
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-04-27 20:50 UTC by Report Bug Copy Issue Report This re-assigns to the parameter `pattern`. Re-assigning to parameters often makes code less readable, consider introducing a new variable instead. Loading history...
126			route = crossroads.addRoute(pattern, handler, priority);
127
128			if(greedy !== false) {
129			route.greedy = true;
130			}
131
132			return route;
133			},
134
135			/**
136			* Render given URL, defaults to the current backend URL
137			*
138			* @param {String} url
139			* The URL of the view that should be rendered, optional
140			* @param {Boolean} greedy
141			* Determines, if only the first or all matching views are rendered,
142			* defaults to `true (all)
143			*/
144			render: function renderRoute(url, greedy) {
145
146			if(!url) {
147
148			url = Symphony.Context.get('path') + Symphony.Context.get('route');
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-04-27 20:50 UTC by Report Bug Copy Issue Report This re-assigns to the parameter `url`. Re-assigning to parameters often makes code less readable, consider introducing a new variable instead. Loading history...
149			}
150
151			if(greedy === false) {
152			crossroads.greedyEnabled = false;
153			}
154
155			crossroads.parse(url);
156			}
157
158			},
159
160			/**
161			* Storage for the main Symphony elements`.
162			* Symphony automatically adds all main UI areas.
163			*
164			* @since Symphony 2.4
165			*/
166			Elements: {
167			window: null,
168			html: null,
169			body: null,
170			wrapper: null,
171			header: null,
172			nav: null,
173			session: null,
174			context: null,
175			contents: null
176			},
177
178			/**
179			* The Context object contains general information about the system,
180			* the backend, the current user. It includes an add and a get function.
181			* This is a private object and can only be accessed via add and get.
182			*
183			* @class
184			*/
185			Context: {
186
187			/**
188			* Add data to the Context object
189			*
190			* @param {String} group
191			* Name of the data group
192			* @param {String\|Object} values
193			* Object or string to be stored
194			*/
195			add: function addContext(group, values) {
196
197			// Add multiple groups
198			if(!group && $.type(values) === 'object') {
199			$.extend(Storage.Context, values);
200			}
201
202			// Add to existing group
203			else if(Storage.Context[group] && $.type(values) !== 'string') {
204			$.extend(Storage.Context[group], values);
205			}
206
207			// Add new group
208			else {
209			Storage.Context[group] = values;
210			}
211
212			// Always return
213			return true;
214			},
215
216			/**
217			* Get data from the Context object
218			*
219			* @param {String} group
220			* Name of the group to be returned
221			*/
222			get: function getContext(group) {
223
224			// Return full context, if no group is set
225			if(!group) {
226			return Storage.Context;
227			}
228
229			// Return false if group does not exist in Storage
230			if(typeof Storage.Context[group] === 'undefined') {
231			return false;
232			}
233
234			// Default: Return context group
235			return Storage.Context[group];
236			}
237			},
238
239			/**
240			* The Language object stores the dictionary with all needed translations.
241			* It offers public functions to add strings and get their translation and
242			* it offers private functions to handle variables and get the translations via
243			* an synchronous AJAX request.
244			* Since Symphony 2.3, it is also possible to define different translations
245			* for the same string, by using page namespaces.
246			* This is a private object
247			*
248			* @class
249			*/
250			Language: {
251
252			/**
253			* Add strings to the Dictionary
254			*
255			* @param {Object} strings
256			* Object with English string as key, value should be false
257			*/
258			add: function addStrings(strings) {
259
260			// English system
261			if(Symphony.Context.get('lang') === 'en') {
262			$.extend(true, Storage.Dictionary, strings);
263			}
264
265			// Localised system
266			else {
267
268			// Check if strings have already been translated
269			$.each(strings, function checkStrings(index, key) {
270			if(key in Storage.Dictionary) {
271			delete strings[key];
272			}
273			});
274
275			// Translate strings
276			if(!$.isEmptyObject(strings)) {
277			translate(strings);
278			}
279			}
280			},
281
282			/**
283			* Get translated string from the Dictionary.
284			* The function replaces variables like {$name} with the a specified value if
285			* an object of inserts is passed in the function call.
286			*
287			* @param {String} string
288			* English string to be translated
289			* @param {Object} inserts
290			* Object with variable name and value pairs
291			* @return {String}
292			* Returns the translated string
293			*/
294			get: function getString(string, inserts) {
295			var translation = Storage.Dictionary[string];
296
297			// Validate and set translation
298			if($.type(translation) === 'string') {
299			string = translation;
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-04-27 20:50 UTC by Report Bug Copy Issue Report This re-assigns to the parameter `string`. Re-assigning to parameters often makes code less readable, consider introducing a new variable instead. Loading history...
300			}
301
302			// Insert variables
303			string = replaceVariables(string, inserts);
304
305			// Return translated string
306			return string;
307			}
308			},
309
310			/**
311			* A collection of properties that represent the presence of
312			* different browser features and also contains the test results
313			* from jQuery.support.
314			*
315			* @class
316			*/
317			Support: Storage.Support,
318
319			/**
320			* A namespace for core interface components
321			*
322			* @since Symphony 2.6
323			*/
324			Interface: {},
325
326			/**
327			* A namespace for extension to store global functions
328			*
329			* @since Symphony 2.3
330			*/
331			Extensions: {},
332
333			/**
334			* Helper functions
335			*
336			* @since Symphony 2.4
337			*/
338			Utilities: {
339
340			/**
341			* Get a jQuery object of all elements within the current viewport
342			*
343			* @since Symphony 2.4
344			*/
345			inSight: function inSight(elements) {
346			var windowHeight = window.innerHeight,
347			visibles = $();
348
349			elements.each(function() {
350			var context = this.getBoundingClientRect();
351
352			if(
353			(context.top >= 0 && context.top <= windowHeight) \|\| // Element top in sight
354			(context.bottom >= 0 && context.bottom <= windowHeight) \|\| // Element bottom in sight
355			(context.top <= 0 && context.bottom >= windowHeight) // Element overflowing viewport
356			) {
357			visibles = visibles.add(this);
			0 ignored issues – show Best Practice introduced 2018-04-27 20:50 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
358			}
359			else if (visibles.length > 0) {
			0 ignored issues – show Complexity Best Practice introduced 2018-04-27 20:50 UTC by Report Bug Copy Issue Report There is no return statement if `visibles.length > 0` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
360			return false;
361			}
362			});
363
364			return visibles;
365			},
366
367			/**
368			* Returns the XSRF token for the backend
369			*
370			* @since Symphony 2.4
371			* @param boolean $serialised
372			* If passed as true, this function will return the string as a serialised
373			* form elements, ie. field=value. If omitted, or false, this function
374			* will just return the XSRF token.
375			*/
376			getXSRF: function(serialised) {
377			var xsrf = Symphony.Elements.contents.find('input[name=xsrf]').val();
378
379			if(serialised === true) {
380			return 'xsrf=' + encodeURIComponent(xsrf);
381			}
382			else {
			0 ignored issues – show Comprehensibility introduced 2018-04-27 20:50 UTC by Report Bug Copy Issue Report `else` is not necessary here since all `if` branches return, consider removing it to reduce nesting and make code more readable. Loading history...
383			return xsrf;
384			}
385			},
386
387			/**
388			* Cross browser wrapper around requestFrameAnimation
389			*
390			* @since Symphony 2.5
391			* @param function $func
392			* The callback to schedule for frame animation
393			*/
394			requestAnimationFrame: function (func) {
395			return raf.call(window, func);
396			},
397
398			/**
399			* Cross browser wrapper around cancelAnimationFrame
400			*
401			* @since Symphony 2.5
402			* @param Integer $t
403			* The request id
404			*/
405			cancelAnimationFrame: function (t) {
406			return craf.call(window, t);
407			}
408			}
409			};
410			}(window.jQuery, window.crossroads));
411

symphonycms / symphony-2

GitHub Access Token became invalid

Pull Request — master (#2833)

Symphony.constructor B

Complexity

Size

Duplication

Importance

18 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like